Skip to content

fix: Fixes borders, dark mode highlight, and actions padding style issues #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pan-kot merged 3 commits into from
Jan 7, 2025
Merged

fix: Fixes borders, dark mode highlight, and actions padding style issues #57

pan-kot merged 3 commits into from
Jan 7, 2025

Conversation

@pan-kot
Copy link
Member

@pan-kot pan-kot commented Jan 6, 2025

Description

Fixing issues introduced here: 5381da5

  1. Rounded borders are missing;
  2. Dark mode highlight styles are not applied;
  3. No space is reserved for actions.

Before:

Screen.Recording.2025-01-06.at.14.50.56.mov

After:

Screen.Recording.2025-01-06.at.14.51.45.mov

How has this been tested?

  • Manual checking
  • Screenshot tests
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pan-kot pan-kot marked this pull request as ready for review January 6, 2025 13:55
@pan-kot pan-kot requested a review from a team as a code owner January 6, 2025 13:55
@pan-kot pan-kot requested review from akoreman and just-boris and removed request for a team January 6, 2025 13:55
@codecov
Copy link

codecov bot commented Jan 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f3e1063) to head (3e8b339).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main       #57   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines          383       383           
  Branches        30        30           
=========================================
  Hits           383       383

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

just-boris
just-boris previously approved these changes Jan 6, 2025
View reviewed changes
@pan-kot
Copy link
Member Author

pan-kot commented Jan 6, 2025

@just-boris , I added a commit re-introducing explicit background color to line numbers to fix the overlapping issue:

image

@pan-kot pan-kot requested a review from just-boris January 6, 2025 15:48
@pan-kot pan-kot added this pull request to the merge queue Jan 6, 2025
@pan-kot pan-kot removed this pull request from the merge queue due to a manual request Jan 6, 2025
@pan-kot pan-kot added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit fdebd0b Jan 7, 2025
39 of 40 checks passed
@pan-kot pan-kot deleted the fix-styles branch January 7, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@just-boris just-boris just-boris approved these changes

@akoreman akoreman akoreman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pan-kot @just-boris @akoreman